-
Notifications
You must be signed in to change notification settings - Fork 159
feat: .env UI editor #8520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: .env UI editor #8520
Conversation
|
where to consolidate utils? have the same functions and lots of repeat since they are the same functionality |
looks like we didnt habe this already so claude code/cursor did some work and i rebuild proto... since its new feature it shouldnt effect anything else
|
@begelundmuller , based on Mike's requests to add push-pull button in the UI here: https://rilldata.slack.com/archives/C01A9DYP013/p1765989576246559?thread_ts=1765901488.470909&cid=C01A9DYP013 required some new backend changes, so tagging you as a reviewer for this PR, as well. If this is "too complicated" or adds brittleness to the code base, we can remove the backend changes and buttons for this PR and tackle it in a dedicated PR in the future. Thoughts? |
begelundmuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend code here seems correct at a high level, although it could do with some cleaning up (there are some anti-patterns and no tests)



Copy paste and Claude Code the UI editor from RC to RD.
Not sure what the folder arch is but .env editor is in
web-admin/and copied toweb-common/for RD. Since its pretty much a replica, can point it to the same file to reduce code dupe but they are slight different spaces so wanted to do them separately on first pass.Checklist: