Skip to content

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Dec 16, 2025

Copy paste and Claude Code the UI editor from RC to RD.
Not sure what the folder arch is but .env editor is in web-admin/ and copied to web-common/ for RD. Since its pretty much a replica, can point it to the same file to reduce code dupe but they are slight different spaces so wanted to do them separately on first pass.

Screenshot 2025-12-16 at 10 50 57

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@royendo
Copy link
Contributor Author

royendo commented Dec 16, 2025

where to consolidate utils?
web-common/src/features/environment-variables/utils.ts
and
web-admin/src/features/projects/environment-variables/utils.ts

have the same functions and lots of repeat since they are the same functionality

@royendo
Copy link
Contributor Author

royendo commented Dec 17, 2025

Before Deploy: Screenshot 2025-12-17 at 13 25 34

After Deploy: Screenshot 2025-12-17 at 13 26 54

Code view Before Deploy:
Screenshot 2025-12-17 at 14 37 39

looks like we didnt habe this already so claude code/cursor did some work and i rebuild proto...
since its new feature it shouldnt effect anything else
@royendo royendo requested a review from mindspank December 17, 2025 19:17
@royendo
Copy link
Contributor Author

royendo commented Dec 17, 2025

@begelundmuller , based on Mike's requests to add push-pull button in the UI here: https://rilldata.slack.com/archives/C01A9DYP013/p1765989576246559?thread_ts=1765901488.470909&cid=C01A9DYP013

required some new backend changes, so tagging you as a reviewer for this PR, as well.

If this is "too complicated" or adds brittleness to the code base, we can remove the backend changes and buttons for this PR and tackle it in a dedicated PR in the future.

Thoughts?

Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend code here seems correct at a high level, although it could do with some cleaning up (there are some anti-patterns and no tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants