fix: server binding 0.0.0.0 for useLocalIp only #2778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Set the binding host to 0.0.0.0 only the user sets useLocalIp = true. Otherwise, users may mistakenly assume that the website can only be accessed locally, when in fact it is anonymously accessible throughout the entire LAN, which could create a security vulnerability.
[X] Bugfix [ ] Feature [ ] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other: <!-- Please describe: -->What is the current behavior?
Live server is always binding to 0.0.0.0 (include localhost IP and all network adapter IP)
Issue Number: N/A
What is the new behavior?
When user set useLocalIp = true, live server bind to host 0.0.0.0, otherwise it bind to the setting from Config.getHost.
Does this PR introduce a breaking change?
According to the existing documentation, users would understand that without setting "useLocalIp", access is limited to the local machine. However, the current situation opens up unused external access, and this change should not affect existing usage.
Other information