Skip to content

Fix app crashing when applying auto layout on tabbaritems. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix app crashing when applying auto layout on tabbaritems. #35

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f0ac9
Fix app crashing when applying auto layout on tabbaritems.
doggy Dec 10, 2014
c79c6e3
some updates for supporting auto-layout animation
doggy Dec 11, 2014
46be587
Merge commit 'b53d990a11dff65ffc4eb930dc3204f19409ac95'
doggy Apr 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 28 additions & 23 deletions RDVTabBarController/RDVTabBar.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,33 +61,38 @@ - (void)commonInitialization {
}

- (void)layoutSubviews {
CGSize frameSize = self.frame.size;
CGFloat minimumContentHeight = [self minimumContentHeight];

[[self backgroundView] setFrame:CGRectMake(0, frameSize.height - minimumContentHeight,
frameSize.width, frameSize.height)];

[self setItemWidth:roundf((frameSize.width - [self contentEdgeInsets].left -
[self contentEdgeInsets].right) / [[self items] count])];

NSInteger index = 0;

// Layout items

for (RDVTabBarItem *item in [self items]) {
CGFloat itemHeight = [item itemHeight];
// Is it exist Autolayout??
if (self.translatesAutoresizingMaskIntoConstraints) {
CGSize frameSize = self.frame.size;
CGFloat minimumContentHeight = [self minimumContentHeight];

if (!itemHeight) {
itemHeight = frameSize.height;
}
[[self backgroundView] setFrame:CGRectMake(0, frameSize.height - minimumContentHeight,
frameSize.width, frameSize.height)];

[self setItemWidth:roundf((frameSize.width - [self contentEdgeInsets].left -
[self contentEdgeInsets].right) / [[self items] count])];

[item setFrame:CGRectMake(self.contentEdgeInsets.left + (index * self.itemWidth),
roundf(frameSize.height - itemHeight) - self.contentEdgeInsets.top,
self.itemWidth, itemHeight - self.contentEdgeInsets.bottom)];
[item setNeedsDisplay];
NSInteger index = 0;

index++;
// Layout items

for (RDVTabBarItem *item in [self items]) {
CGFloat itemHeight = [item itemHeight];

if (!itemHeight) {
itemHeight = frameSize.height;
}

[item setFrame:CGRectMake(self.contentEdgeInsets.left + (index * self.itemWidth),
roundf(frameSize.height - itemHeight) - self.contentEdgeInsets.top,
self.itemWidth, itemHeight - self.contentEdgeInsets.bottom)];
[item setNeedsDisplay];

index++;
}
}

[super layoutSubviews];
}

#pragma mark - Configuration
Expand Down