POC for video URLS #1755
Closed
POC for video URLS #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # When video_url or rtsp_url is provided, frames come from the URL, not the data channel | ||
| use_data_channel_frames = webrtc_request.use_data_channel_frames | ||
| if webrtc_request.video_url or webrtc_request.rtsp_url: |
Collaborator
There was a problem hiding this comment.
Would we want to send frames sequentially over data channel if requested by user?
Contributor
Author
There was a problem hiding this comment.
You mean in what direction?
User receiving frames through datachannel 🆗
User sending frames to inference through datachannel when it is already sending a video url. ⛔
Collaborator
|
Dropped in favor or whole video file streamed upfront over data channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only a test that needs to be run on staging to validate if it improves overall experience.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
YOUR_ANSWER
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs