Skip to content

Conversation

@rozukke
Copy link
Owner

@rozukke rozukke commented Feb 15, 2025

Includes the following:

  • More consistent naming and casing (excluding legacy endpoints)
  • Lint using clang-tidy with included config and opportunity to enable in CI
  • Switch to unique_ptr and add associated constructors
  • Template parsing
  • Significant memory savings by using correctly sized types

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v12.0.0

Click here for the full clang-format patch
diff --git a/include/mcpp/block.h b/include/mcpp/block.h
index dc9ce79..747ae11 100644
--- a/include/mcpp/block.h
+++ b/include/mcpp/block.h
@@ -17 +17 @@ public:
-  constexpr BlockType(uint8_t id = 0, uint8_t mod = 0) : id(id), mod(mod) {};
+  constexpr BlockType(uint8_t id = 0, uint8_t mod = 0) : id(id), mod(mod){};
diff --git a/src/connection.cpp b/src/connection.cpp
index d8d3368..1e049a4 100644
--- a/src/connection.cpp
+++ b/src/connection.cpp
@@ -36 +36 @@ std::string SocketConnection::resolve_hostname(const std::string& hostname) {
-  struct addrinfo hints{};
+  struct addrinfo hints {};

Have any feedback or feature suggestions? Share it here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review February 15, 2025 06:06

outdated suggestion

@rozukke rozukke merged commit abe180a into main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants