Add html lang test and more #3744
Open
+50
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ang-plugin` for consistency with plugin naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive tests for the
to_html_langfilter, and improves language code handling and accessibility in the language selector. It has the nature of reinforcing #3718.Testing and filter correctness:
test/test_plugin_html_lang.rbto thoroughly test theJekyll::HtmlLangFilter#to_html_langmethod, ensuring correct conversion from Jekyll locale format (e.g.,zh_cn) to BCP 47 format (e.g.,zh-CN), proper handling of non-string inputs, and integration with Liquid templates. This test code was generated using RubyMine's Junie. This facilitates maintenance.Language selector accessibility and semantics:
_includes/language_selector.htmlto wrap language codes with<span lang="und-Latn">and<span lang="en">for English, improving accessibility and semantic correctness.