riscv-rt: remove general-purpose register zeroing
#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Jun 26, 2025
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Makes sense, we don't zero the gp/fp registers in esp-riscv-rt either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the best of my knowledge, zeroing general-purpose registers is not required at all. In fact, after zeroing them, the boot process uses a few temporary registers and leaves them dirty when jumping to main.
I checked the
cortex-m-rtsource code, and it seems that they do not clear general-purpose registers. Thus, I guess that it is not harmful to shrink the boot process a bit.