Skip to content

chore: update octocrab to version 0.42 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kobzol merged 1 commit into from
Nov 15, 2024
Merged

chore: update octocrab to version 0.42 #174

Kobzol merged 1 commit into from
Nov 15, 2024

Conversation

@marcoieni
Copy link
Member

@marcoieni marcoieni commented Nov 15, 2024 •
edited
Loading

EDIT: tests are failing. the regression is introduced in 0.39

@marcoieni marcoieni mentioned this pull request Nov 15, 2024
Closed
1 task
@Kobzol
Copy link
Member

Kobzol commented Nov 15, 2024

I'm quite sure that updating octocrab breaks bors (it does compile, but some behavior changes). We'd need to change code to make it work.

@marcoieni marcoieni marked this pull request as draft November 15, 2024 14:33
@marcoieni marcoieni mentioned this pull request Nov 15, 2024
Closed
@marcoieni marcoieni force-pushed the chore-update-octocrab-to-version-0.42 branch from 8c88671 to 7e759f1 Compare November 15, 2024 15:25
@marcoieni marcoieni marked this pull request as ready for review November 15, 2024 15:30
@marcoieni marcoieni requested a review from Kobzol November 15, 2024 17:04
Kobzol
Kobzol approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so LGTM :)

@Kobzol Kobzol added this pull request to the merge queue Nov 15, 2024
Merged via the queue into rust-lang:main with commit 84d9724 Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcoieni @Kobzol