Add elapsed time in pending status

[bncer]

Closes #371

Display elapsed time

Currently it's not live, it shows within template.

[bncer]

In order to show expected time it seems like I need to store success build duration from Github, database doesn't contain any related information.

[Kobzol]

I think we can do that in several steps (multiple PRs). It is enough to just show the elapsed time in the first PR (this one). Thank you! I will take a look tomorrow.

[Kobzol]

Thank you! Left a few comments.

[Kobzol]

Looks great, thanks! Left one additional comment.

Once you add the <title>, it would be great to get rid of the merge commit. You can do that e.g. by git fetch origin && git rebase origin/main (assuming that your remote is called origin, it could also be upstream or something else).

[bncer]

I faced an issue with sqlx during compilation:

the trait bound `i32: From<std::option::Option<i32>>` is not satisfied
   --> src/database/operations.rs:136:22
    |
136 |           let record = sqlx::query_as!(
    |  ______________________^
137 | |             PullRequestModel,
138 | |             r#"
139 | |             WITH upserted_pr AS (
...   |
183 | |             params.pr_status as _,
184 | |         )
    | |_________^ the trait `From<std::option::Option<i32>>` is not implemented for `i32`

Sqlx thinks some columns nullable, even though in database these fields specified as Not Null.

[Kobzol]

Could you share the code where that happens?

[bncer]

Could you share the code where that happens?

in src/database/operations.rs in upsert_pull_request function
and src/database/operations.rs in update_mergeable_states_by_base_branch function

After several hours I built bors and it worked without any errors. But I tried to reproduce this by: cargo clean, rm -rf .sqlx and it fails again 😆

[bncer]

With sqlx's exclamation mark (!) I lowered number of errors, but clear reason of different behavior blows my mind

### diff --git a/src/database/operations.rs b/src/database/operations.rs
index 6d31e9b..bce49ee 100644
--- a/src/database/operations.rs
+++ b/src/database/operations.rs
@@ -151,22 +151,22 @@ pub(crate) async fn upsert_pull_request(
             )
             SELECT
                 pr.id,
-                pr.repository as "repository: GithubRepoName",
+                pr.repository as "repository!: GithubRepoName",
                 pr.number as "number!: i64",
                 pr.title,
                 pr.author,
-                pr.assignees as "assignees: Assignees",
+                pr.assignees as "assignees!: Assignees",
                 (
                     pr.approved_by,
                     pr.approved_sha
                 ) AS "approval_status!: ApprovalStatus",
-                pr.status as "pr_status: PullRequestStatus",
+                pr.status as "pr_status!: PullRequestStatus",
                 pr.priority,
-                pr.rollup as "rollup: RollupMode",
-                pr.delegated_permission as "delegated_permission: DelegatedPermission",
+                pr.rollup as "rollup!: RollupMode",
+                pr.delegated_permission as "delegated_permission!: DelegatedPermission",
                 pr.base_branch,
-                pr.mergeable_state as "mergeable_state: MergeableState",
-                pr.created_at as "created_at: DateTime<Utc>",
+                pr.mergeable_state as "mergeable_state!: MergeableState",
+                pr.created_at as "created_at!: DateTime<Utc>",
                 try_build AS "try_build: BuildModel",
                 auto_build AS "auto_build: BuildModel"
             FROM upserted_pr as pr

[Kobzol]

Hmm, that's weird. What Postgres version are you using? Does this happen in cargo build, or where are the errors popping up?

[bncer]

I'm using postgres:16.9, which was specified in docker-compose.yml.
Yes, it was showing up in cargo build command.

For now I will leave it until I face again.

[bncer]

I placed <table class="stripe"> to the right place from MR #463, otherwise it was creating two tables

[Kobzol]

Left one nit about the started date title. Thanks for catching the duplicated table!

[Kobzol]

Thank you! It looks great.