Preserve explicit lifetime information when removing mut
#16273
+186
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than trying to reconstruct the reference type without the `mut`, remove the `mut` itself so that user-inserted lifetime information is preserved. The message has been changed from "consider changing to [NON-MUT REF]" to "remove this `mut`"
rustbot
added
the
S-waiting-on-review
Collaborator
|
Lintcheck changes for dcb19a0
This comment will be updated if you push new changes |
Jarcho
reviewed
Dec 21, 2025
| sp, | ||
| "consider changing to".to_string(), | ||
| format!("&{}", snippet(cx, cx.tcx.hir_span(inner_ty.ty.hir_id), "_"),), | ||
| mut_span, |
Contributor
There was a problem hiding this comment.
Is there any reason not to use this as the lint span?
Member
Author
There was a problem hiding this comment.
Given the existing message ("this argument is a mutable reference, but not used mutably") it makes sense to point to the whole argument when linting.
I'll change this to "this parameter is a mutable reference but is not used mutably" which is more correct though.
Tell me if you want me to change the span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to reconstruct the reference type without the
mut, remove themutitself so that user-inserted lifetime information is preserved.The message has been changed from "consider changing to [NON-MUT REF]" to "remove this
mut"changelog: [
needless_pass_by_ref_mut]: preserve user-provided lifetime informationFixes #16267