Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Oct 24, 2025

Backfills many of the missing Zulip user IDs. This was done by using three heuristics (in three commits), in decreasing level of confidence:

  • Matching Zulip name with the GitHub username.
  • Matching Zulip name with the team DB name.
  • Matching Zulip name with the GItHub name.

I only included matches where there was exactly one Zulip account matched (ignored duplicates). All matches were done with lowercase normalization, but without Unicode normalization.

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github

@Kobzol Kobzol force-pushed the backfill-zulip-ids branch from 9686992 to 0fd7141 Compare October 24, 2025 20:28
@Kobzol Kobzol mentioned this pull request Oct 24, 2025
@Kobzol Kobzol force-pushed the backfill-zulip-ids branch from 9bc4efb to 63d31ed Compare October 25, 2025 15:41
@jieyouxu jieyouxu added T-infra Relevant to the infrastructure team. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Oct 27, 2025
@jieyouxu jieyouxu self-assigned this Oct 27, 2025
@Kobzol Kobzol force-pushed the backfill-zulip-ids branch from 63d31ed to 1bb7fed Compare October 30, 2025 08:33
@Kobzol Kobzol force-pushed the backfill-zulip-ids branch from 1bb7fed to 2202a4d Compare November 1, 2025 10:25
@Kobzol
Copy link
Member Author

Kobzol commented Nov 1, 2025

I found some duplicates with my matching script, where a single GitHub account was matched to multiple Zulip accounts by my name matching heuristic:

User: Person { name: "Dhruv Jauhar", github: "null-sleep", github_id: 13277988, zulip_id: None, irc: None, email: Explicit(None), discord_id: None, matrix: None, permissions: Permissions { bors: {}, booleans: {} } } matched with multiple Zulip accounts:
[ZulipUser { user_id: 282466, name: "Dhruv Jauhar", profile_data: {} }, ZulipUser { user_id: 282558, name: "Dhruv Jauhar", profile_data: {} }]

User: Person { name: "Tom Prince", github: "tomprince", github_id: 283816, zulip_id: None, irc: None, email: Explicit(Some("[email protected]")), discord_id: None, matrix: None, permissions: Permissions { bors: {}, booleans: {} } } matched with multiple Zulip accounts:
[ZulipUser { user_id: 407597, name: "Tom Prince", profile_data: {} }, ZulipUser { user_id: 119280, name: "Tom Prince", profile_data: {} }]

User: Person { name: "Daniel Egger", github: "therealprof", github_id: 3321888, zulip_id: None, irc: None, email: Explicit(Some("[email protected]")), discord_id: None, matrix: None, permissions: Permissions { bors: {}, booleans: {} } } matched with multiple Zulip accounts:
[ZulipUser { user_id: 392749, name: "Daniel Egger", profile_data: {} }, ZulipUser { user_id: 263083, name: "Daniel Egger", profile_data: {} }]

User: Person { name: "Ryan", github: "ryankurte", github_id: 860620, zulip_id: None, irc: None, email: Disabled(false), discord_id: None, matrix: None, permissions: Permissions { bors: {}, booleans: {} } } matched with multiple Zulip accounts:
[ZulipUser { user_id: 249469, name: "Ryan", profile_data: {} }, ZulipUser { user_id: 460074, name: "Ryan", profile_data: {} }]

User: Person { name: "Daniel Silverstone", github: "kinnison", github_id: 1469421, zulip_id: None, irc: None, email: Explicit(Some("[email protected]")), discord_id: None, matrix: None, permissions: Permissions { bors: {}, booleans: {} } } matched with multiple Zulip accounts:
[ZulipUser { user_id: 389398, name: "Daniel Silverstone", profile_data: {} }, ZulipUser { user_id: 223910, name: "Daniel Silverstone", profile_data: {} }]

User: Person { name: "Brad Gibson", github: "U007D", github_id: 2874989, zulip_id: None, irc: None, email: Explicit(Some("[email protected]")), discord_id: None, matrix: None, permissions: Permissions { bors: {}, booleans: {} } } matched with multiple Zulip accounts:
[ZulipUser { user_id: 437845, name: "U007D", profile_data: {} }, ZulipUser { user_id: 880714, name: "U007D", profile_data: {} }]

@null-sleep @tomprince @therealprof @ryankurte @kinnison @U007D Could you please send me your Zulip account ID that you use? The list above should show some Zulip accounts that might be yours.

@kinnison
Copy link
Contributor

kinnison commented Nov 5, 2025

@kinnison Could you please send me your Zulip account ID that you use? The list above should show some Zulip accounts that might be yours.

@Kobzol "Use" is a loaded term, but the ID I have if I log in with my github account is 223910

D.

@Kobzol Kobzol force-pushed the backfill-zulip-ids branch from 30b68a9 to 419d530 Compare November 5, 2025 19:03
@Kobzol
Copy link
Member Author

Kobzol commented Nov 5, 2025

Yeah, it's mostly about having the IDs in the DB, we don't "require" people to actively use Zulip, ofc.

There are two Zulip accounts with this name, but this one should be the right one, as it was active recently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. T-infra Relevant to the infrastructure team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants