-
Notifications
You must be signed in to change notification settings - Fork 326
Add validation for duplicate team entries #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dry-run check results |
|
I tried open the link from #2032 (comment) And it seems like it was disabled due to inactivity, so I updated link, so you can see https://github.com/rust-lang/team/compare/main...Kivooeo:team:add-check?expand=1, how I made this and read this comment above about some details, but I lean to this solution because it does account leads as well without repeating logic in check function |
|
Yes @Kivooeo , I saw your pr and i agree with your approach but i do not know if i can change the schema.rs as that was not specified in the pr and that is the cleanest way to handle team leads and I want to see the errors that needs to resolve in a single check so that i can solve the issue, so that is why i avoided bail!() , if i used that then your code works perfectly. @marcoieni any thoughts? |
|
you can change schema.rs, for sure! |
201e079 to
35fc992
Compare
- Add explicit_leads() method to expose team leads - Add validate_duplicate_team_entries() to check for duplicates - Check leads, members, and alumni for duplicates - Collect all errors for better developer experience
2ccbf35 to
c318366
Compare
|
@marcoieni just updated the code with the new requirements |
This PR adds validation to check for duplicate entries in team members and alumni lists.
Fixes rust-lang/team #1918
Changes:
validate_duplicate_team_entriesfunction