Rename GuestMemory->GuestMemoryBackend, IoMemory->GuestMemory #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of the function is exactly to change a pointer obtained from a mutable VolatileSlice into a reference, and doing so is unsafe. So just shut up clippy. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
requested review from
ShadowCurse,
XanClic,
alexandruag,
jiangliu and
roypat
as code owners
Rename GuestMemory to GuestMemoryBackend, IoMemory to GuestMemory. This allows users of vm-memory to be aware of access permissions for memory, with no change to callers that just use the `Bytes` interface. Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
After the rename, the primary interface to vm-memory is almost completely absent in DESIGN.md. Give it more importance and remove some details of GuestMemoryBackend that are now obsolete. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
rename-iomemory
branch
from
10ec8d3 to
a97d0e1
Compare
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
rename-iomemory
branch
from
a97d0e1 to
569b637
Compare
Member
Author
|
I'm not sure if this should be 0.18.0 or 0.19.0. @XanClic, I think the current |
bonzini
changed the title
4 tasks
likebreath
reviewed
Nov 7, 2025
| `GuestMemory`; therefore, all callers that just use the `Bytes` interface | ||
| remain completely unchanged. | ||
|
|
||
| - \[[#362](https://github.com/rust-vmm/vm-memory/pull/362)\] Rename `GuestMemory` to `GuestMemoryBackend`, `IoMemory` to `GuestMemoryBackend` |
Contributor
There was a problem hiding this comment.
Typo: IoMemory to GuestMemoryBackendGuestMemory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
As discussed in #327, make the main interface to vm-memory the one that includes permissions and lets fewer aspects of the implementation through.
Based on #361.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.