Fix i8/u8 discrepancy for Language enum #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaF1
requested review from
AzureMarker,
FenrirWolf,
Meziu and
ian-h-chamberlain
FenrirWolf
approved these changes
Nov 8, 2024
AzureMarker
approved these changes
Nov 8, 2024
|
Wouldn't it be better to change the |
|
Yeah that works too. I initially thought that changing the type might break things in other places, but I just tried it out (master...DeltaF1:ctru-rs:language_repr_2) and it builds fine so I guess nothing was depending on the repr. |
DeltaF1
force-pushed
the
language_repr
branch
from
8aaaa6c to
cc98398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195