Update ctru-rs to the 2024 edition. #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adryzz
approved these changes
Apr 1, 2025
Contributor
adryzz
left a comment
adryzz
left a comment
There was a problem hiding this comment.
so much better without those macros, well done
ian-h-chamberlain
approved these changes
Apr 4, 2025
Member
ian-h-chamberlain
left a comment
ian-h-chamberlain
left a comment
There was a problem hiding this comment.
LGTM, this might also be a good opportunity to clean up clippy warnings in other files since this upgrade likely introduces some new ones.
At one point long ago I was considering adding -D warnings to ci.yml (for the pinned toolchain job) but guess I never got around to it
ian-h-chamberlain
added a commit
to rust3ds/actions
that referenced
this pull request
Apr 4, 2025
We might actually want a more recent toolchain to support rust3ds/ctru-rs#214 but I'm just testing things for now
ian-h-chamberlain
added a commit
to rust3ds/actions
that referenced
this pull request
Apr 4, 2025
We might actually want a more recent toolchain to support rust3ds/ctru-rs#214 but I'm just testing things for now
ian-h-chamberlain
added a commit
to rust3ds/actions
that referenced
this pull request
Apr 4, 2025
We might actually want a more recent toolchain to support rust3ds/ctru-rs#214 but I'm just testing things for now
FenrirWolf
force-pushed
the
update_edition
branch
from
597bce9 to
fe023e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump CI to a more recent nightly and make use of
&raw const/mutinstead of theaddr_ofmacros.I don't remember if edition updates also mean we should update the crate version number. I could do that too if so.