Don't use pacman to detect and track libctru #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses pacman's output incorrectly and ends up scanning significantly more files than it should. libctru is already assumed to be at $DEVKITPRO/libctru earlier in the file. This is slightly more naive because it assumes libctru doesn't place files outside of $DEVKITPRO/libctru, but also it doesn't and obviously shouldn't. For me incremental (hot? warm? the opposite of cold) build times went down from ~20 seconds to <0.2.
CenTdemeern1
requested review from
AzureMarker,
FenrirWolf,
Meziu and
ian-h-chamberlain
|
Looks good to me. I'll have to take another look at that build script later on too. I get the feeling there are other things that could be simplified a little in there, but that would be a story for another time. |
FenrirWolf
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some code in the build script that uses pacman's output incorrectly and ends up scanning significantly more files than it should, and replaces it with a naive but functional alternative.
libctru is already assumed to be at $DEVKITPRO/libctru earlier in the file:
ctru-rs/ctru-sys/build.rs
Line 33 in 999dd61
This is slightly more naive because it assumes libctru doesn't place files outside of $DEVKITPRO/libctru, but also it doesn't and obviously shouldn't.
For me warm build times went down from ~20 seconds to <0.2.
Fixes #233 (and #201)