Skip to content

Revise presigned URL documentation structure #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loverustfs merged 1 commit into from
Dec 26, 2025
Merged

Revise presigned URL documentation structure #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions docs/developer/sdk/java.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,7 @@ Good, below is the **RustFS AWS S3 Java SDK Advanced Features Example Supplement

> Presigned URLs allow clients to temporarily access private objects without exposing credentials, widely used for browser direct upload or download file scenarios.

#### 5.1.1 Add Dependencies (v2 SDK URL signing is in `s3-presigner` module)

```xml
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>s3-presigner</artifactId>
<version>2.25.27</version>
</dependency>
```

#### 5.1.2 Generate Download Link (GET)
#### 5.1.1 Generate Download Link (GET)
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the dependency example creates a gap in the documentation. The presigned URL code examples use S3Presigner from the software.amazon.awssdk.services.s3.presigner package, which requires the s3-presigner artifact. This dependency is not included in the main dependencies section (1.2), which only lists the s3 artifact.

Without this dependency information, users following the documentation will encounter compilation errors when trying to use the presigned URL examples. Either the dependency section should be retained here, or the s3-presigner dependency should be added to the main dependencies section (1.2) with a note about it being required for advanced features like presigned URLs.

Copilot uses AI. Check for mistakes.

```java
import software.amazon.awssdk.services.s3.presigner.S3Presigner;
Expand Down Expand Up @@ -203,7 +193,7 @@ System.out.println("Presigned URL: " + presignedRequest.url());

> 🔗 Open the link in browser to access the object.

#### 5.1.3 Upload Presigned URL (PUT)
#### 5.1.2 Upload Presigned URL (PUT)

Similarly, you can also generate upload URLs:

Expand Down