-
-
Notifications
You must be signed in to change notification settings - Fork 726
Add digits-unicode option to print_mode in p-adic numbers
#41276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Documentation preview for this PR (built with commit 9c033b5; changes) is ready! 🎉 |
|
Can you add a doctest |
|
Looks OK |
The doctest has already been added at line 140-142.
Thank you! |
better leave that to a subsequent pull request. You can create a new branch that builds on top of the commits here and open a new pull request.
Not in Sphinx, in Python doctest module. |
Ok, Sure |
|
Thank you for the review!, I had completely missed that, now reordered the test to match the expected output in the doctest. Also, since this PR was generally for the issue of |
Fixes #41219
Currently, in the doctests, in print_mode = 'digits', the initial characters are
...which are treated as a wildcard entry in sphinx.For example: The below doctest will pass even though the actual answer is
...0000000000000000005FThus the current PR will decode
...using the unicode character…, avoiding any wildcard matching thus preventing any bad error.NOTE: I have currently not updated the docstring/warnings. will do so after review
But test has been added.
testing:
📝 Checklist
⌛ Dependencies