build givaro, fflas-ffpack and linbox without native arch in SAGE_FAT_BINARY #41279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated GIVARO_CONFIGURE to disable architecture-specific optimizations when SAGE_FAT_BINARY is set.
Updated LINBOX_CONFIGURE options for SAGE_FAT_BINARY.
Contributor
Author
|
@vbraun We should merge this before release. |
|
Documentation preview for this PR (built with commit 19dfaa7; changes) is ready! 🎉 |
dimpase
added
s: positive review
p: CI fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41000
Fix #39460
Fix #41273
Fix #41066
Test in #41277
It fixes the docker build and docker runner have different arch.
Refer to passagemath/passagemath#1820
📝 Checklist
⌛ Dependencies