Skip to content

Conversation

@kratsg
Copy link
Contributor

@kratsg kratsg commented Sep 30, 2025

Pull Request Description

Pulled out of #2566. Docs are not building due to various linkcheck errors. Just need to add these to the ignore list.

Also linkcheck gives 403 for some URLs because they're blocking HEADs now... not sure why that changed.

for academic.oup.com

$ curl -A "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:131.0) Gecko/20100101 Firefox/131.0" --head https://academic.oup.com/ptep/article/doi/10.1093/ptep/ptad144/7459362
HTTP/2 403
date: Sat, 21 Dec 2024 15:59:02 GMT
content-type: text/html; charset=UTF-8
content-length: 8743
accept-ch: Sec-CH-UA-Bitness, Sec-CH-UA-Arch, Sec-CH-UA-Full-Version, Sec-CH-UA-Mobile, Sec-CH-UA-Model, Sec-CH-UA-Platform-Version, Sec-CH-UA-Full-Version-List, Sec-CH-UA-Platform, Sec-CH-UA, UA-Bitness, UA-Arch, UA-Full-Version, UA-Mobile, UA-Model, UA-Platform-Version, UA-Platform, UA
critical-ch: Sec-CH-UA-Bitness, Sec-CH-UA-Arch, Sec-CH-UA-Full-Version, Sec-CH-UA-Mobile, Sec-CH-UA-Model, Sec-CH-UA-Platform-Version, Sec-CH-UA-Full-Version-List, Sec-CH-UA-Platform, Sec-CH-UA, UA-Bitness, UA-Arch, UA-Full-Version, UA-Mobile, UA-Model, UA-Platform-Version, UA-Platform, UA
cross-origin-embedder-policy: require-corp
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
origin-agent-cluster: ?1
permissions-policy: accelerometer=(),autoplay=(),browsing-topics=(),camera=(),clipboard-read=(),clipboard-write=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()
referrer-policy: same-origin
x-content-options: nosniff
x-frame-options: SAMEORIGIN
cf-mitigated: challenge
cf-chl-out: kI3rohlrq71KKbX3Nu5hEk+BZm/glZYADDHnftN2mhoifmycVKBIEKZYvPCsVb+xsTEwla38Dd5bmTzO5Zp1DqjaKNHtcAHESRv5Df0hp5cFOzHELElOSA4pTk2t2zdF8wKDrblHVBoC2DQeg2+wvw==$NSFsXK2alPB8IfU0cnzHYA==
cache-control: private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0
expires: Thu, 01 Jan 1970 00:00:01 GMT
set-cookie: __cf_bm=exWKl5QVT3Iw5iQaVpCxbexRIUQTkPiI1lk1izdzRtQ-1734796742-1.0.1.1-BwvBPQzFIvTKf0JO9umxyVZjkbA1Yoi6Ci1uTiHurJ24dBv2dcohoqmsUBkRU3SC_qHJQ5euBC9fT5p4G4HBDg; path=/; expires=Sat, 21-Dec-24 16:29:02 GMT; domain=.academic.oup.com; HttpOnly; Secure; SameSite=None
server: cloudflare
cf-ray: 8f5913baf8e48da6-MIA

for journals.aps.org

$ curl -A "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:131.0) Gecko/20100101 Firefox/131.0" --head https://journals.aps.org/prd/abstract/10.1103/PhysRevD.106.032005
HTTP/2 403
date: Sat, 21 Dec 2024 16:02:20 GMT
content-type: text/html; charset=UTF-8
content-length: 8677
accept-ch: Sec-CH-UA-Bitness, Sec-CH-UA-Arch, Sec-CH-UA-Full-Version, Sec-CH-UA-Mobile, Sec-CH-UA-Model, Sec-CH-UA-Platform-Version, Sec-CH-UA-Full-Version-List, Sec-CH-UA-Platform, Sec-CH-UA, UA-Bitness, UA-Arch, UA-Full-Version, UA-Mobile, UA-Model, UA-Platform-Version, UA-Platform, UA
critical-ch: Sec-CH-UA-Bitness, Sec-CH-UA-Arch, Sec-CH-UA-Full-Version, Sec-CH-UA-Mobile, Sec-CH-UA-Model, Sec-CH-UA-Platform-Version, Sec-CH-UA-Full-Version-List, Sec-CH-UA-Platform, Sec-CH-UA, UA-Bitness, UA-Arch, UA-Full-Version, UA-Mobile, UA-Model, UA-Platform-Version, UA-Platform, UA
cross-origin-embedder-policy: require-corp
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
origin-agent-cluster: ?1
permissions-policy: accelerometer=(),autoplay=(),browsing-topics=(),camera=(),clipboard-read=(),clipboard-write=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()
referrer-policy: same-origin
x-content-options: nosniff
x-frame-options: SAMEORIGIN
cf-mitigated: challenge
cf-chl-out: 1GM7L6OnEIhUA3Nu78SsSXsSZPAKkHusPvR9rzOM+i94tqt6nJbC6KqH+WQcDpnX8c7VY59qsL5H7k14HA/7XtJvoWjCKBm6mKwjXcEfoNtFIA/B+0lWpJumsFsbjBrRK2PmdOH3Uyb6DMRmZXWYCw==$ndOh1e20Lbf2J+XAsQTYgQ==
cache-control: private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0
expires: Thu, 01 Jan 1970 00:00:01 GMT
server: cloudflare
cf-ray: 8f59188e4f4d7469-MIA
alt-svc: h3=":443"; ma=86400

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add more linkcheck ignores to the docs
  - doi.org routes to journals.aps.org or academic.oup.com
  - fnal.gov blocks GitHub Actions
  - GitHub anchor links do not work

@kratsg kratsg added docs Documentation related fix A bug fix chore Other changes that don't modify src or test files labels Sep 30, 2025
@kratsg kratsg self-assigned this Sep 30, 2025
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Sep 30, 2025
@matthewfeickert matthewfeickert changed the title fix: more linkcheck ignore for docs fix: More linkcheck ignore for docs Sep 30, 2025
@kratsg
Copy link
Contributor Author

kratsg commented Sep 30, 2025

Docs build ok. Will merge even though rest of CI fails.

@kratsg kratsg merged commit 135d029 into main Sep 30, 2025
13 of 20 checks passed
@kratsg kratsg deleted the fix/docs branch September 30, 2025 22:26
@github-project-automation github-project-automation bot moved this from In progress to Done in pyhf v0.8.0 Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Other changes that don't modify src or test files docs Documentation related fix A bug fix

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants