chore: Clean up original code to get typehints passing #2608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Linting and pre-commit runs fine -- so these changes improve the type-checking already. |
matthewfeickert
approved these changes
Sep 30, 2025
matthewfeickert
changed the title
matthewfeickert
force-pushed
the
fix/srcCode
branch
from
923ecaa to
e09443b
Compare
Contributor
Author
|
this will fail on |
Member
I don't think this is needed as it isn't required in PR #2625. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is pulled from #2566 to clean up the code to get the typehints passing.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: