Skip to content

Conversation

@matthewfeickert
Copy link
Member

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use uv for all installations in CI, as the Python 3.8 fall back to
  'pip install' was needed only for TensorFlow.
   - Amends PR https://github.com/scikit-hep/pyhf/pull/2609

* Use uv for all installations in CI, as the Python 3.8 fall back to
  'pip install' was needed only for TensorFlow.
   - Amends PR https://github.com/scikit-hep/pyhf/pull/ 2609
@matthewfeickert matthewfeickert self-assigned this Oct 15, 2025
@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Oct 15, 2025
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Oct 15, 2025
@matthewfeickert matthewfeickert marked this pull request as ready for review October 15, 2025 12:53
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (10488f0) to head (b69ff91).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2619   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          65       65           
  Lines        4193     4193           
  Branches      591      591           
=======================================
  Hits         4119     4119           
  Misses         45       45           
  Partials       29       29           
Flag Coverage Δ
contrib 97.97% <ø> (ø)
doctest 98.09% <ø> (ø)
unittests-3.10 96.27% <ø> (ø)
unittests-3.11 96.27% <ø> (ø)
unittests-3.12 96.27% <ø> (ø)
unittests-3.8 96.27% <ø> (ø)
unittests-3.9 96.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit cf7516d into scikit-hep:main Oct 15, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in pyhf v0.8.0 Oct 15, 2025
@matthewfeickert matthewfeickert deleted the ci/remove-non-uv-installs branch October 15, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Other changes that don't modify src or test files CI CI systems, GitHub Actions

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant