Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 17, 2025

Description

  • Use 2i2c as the endpoint to trigger the Binder build given it is the primary endpoint for the Binder federation.
    • The Turing Institute no longer contributes to the Binder federation through compute resources.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use 2i2c as the endpoint to trigger the Binder build given it is
  the primary endpoint for the Binder federation.
   - The Turing Institute no longer contributes to the Binder federation
   through compute resources.
   - c.f. https://mybinder.readthedocs.io/en/latest/about/federation.html

* Use 2i2c as the endpoint to trigger the Binder build given it is
  the primary endpoint for the Binder federation.
   - The Turing Institute no longer contributes to the Binder federation
   through compute resources.
   - c.f. https://mybinder.readthedocs.io/en/latest/about/federation.html
@matthewfeickert matthewfeickert self-assigned this Nov 17, 2025
@matthewfeickert matthewfeickert added Binder Contributing to having Binder build and Binder images run smoothly CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Nov 17, 2025
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Nov 17, 2025
@matthewfeickert matthewfeickert marked this pull request as ready for review November 17, 2025 22:43
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (126e83b) to head (d337632).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2636   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          65       65           
  Lines        4190     4190           
  Branches      453      453           
=======================================
  Hits         4116     4116           
  Misses         45       45           
  Partials       29       29           
Flag Coverage Δ
contrib 98.11% <ø> (ø)
doctest 98.23% <ø> (ø)
unittests-3.10 96.42% <ø> (ø)
unittests-3.11 96.42% <ø> (ø)
unittests-3.12 96.42% <ø> (ø)
unittests-3.13 96.42% <ø> (ø)
unittests-3.9 96.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kratsg kratsg merged commit 6b690c5 into scikit-hep:main Nov 18, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in pyhf v0.8.0 Nov 18, 2025
@matthewfeickert matthewfeickert deleted the ci/fix-binder-trigger branch November 18, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Binder Contributing to having Binder build and Binder images run smoothly chore Other changes that don't modify src or test files CI CI systems, GitHub Actions

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants