Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 20, 2025

Description

  • Add Pixi workspace to pyproject.toml under [tool.pixi] table.
  • Add Pixi lock file to .gitignore.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add Pixi workspace to pyproject.toml under [tool.pixi] table.
* Add Pixi lock file to .gitignore.

* Add Pixi workspace to pyproject.toml under [tool.pixi] table.
* Add Pixi lock file to .gitignore.
@matthewfeickert matthewfeickert self-assigned this Nov 20, 2025
@matthewfeickert matthewfeickert added the feat/enhancement New feature or request label Nov 20, 2025
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (6b690c5) to head (a560690).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          65       65           
  Lines        4190     4190           
  Branches      453      453           
=======================================
  Hits         4116     4116           
  Misses         45       45           
  Partials       29       29           
Flag Coverage Δ
contrib 98.11% <ø> (ø)
doctest 98.23% <ø> (ø)
unittests-3.10 96.42% <ø> (ø)
unittests-3.11 96.42% <ø> (ø)
unittests-3.12 96.42% <ø> (ø)
unittests-3.13 96.42% <ø> (ø)
unittests-3.9 96.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Nov 20, 2025

I've been making heavy use of https://pixi.sh/latest/python/pyproject_toml/#optional-dependencies for this PR and for testing.

I'm also realizing from this PR (/ remembering Issue #2622) that click-completion is in maintenance mode

shellcomplete = ["click_completion"]

and that there is a native Click v8 completion. c.f. https://click.palletsprojects.com/en/stable/shell-completion/#shell-completion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/enhancement New feature or request

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant