Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 27, 2025

Description

Thanks to @ariostas for alerting us to this!

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Disable the PerfPowerServices process on macos-15-intel runners to
  address known macOS 15 bug that significantly slows down the runner.
   - c.f. https://github.com/actions/runner-images/issues/13358

* Disable the PerfPowerServices process on macos-15-intel runners to
  address known macOS 15 bug that significantly slows down the runner.
   - c.f. https://github.com/actions/runner-images/issues/ 13358
@matthewfeickert matthewfeickert self-assigned this Nov 27, 2025
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Nov 27, 2025
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Nov 27, 2025
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Nov 27, 2025

  • Time for macos-15-intel runner to finish in cad5592: 14 minutes.
  • Time for macos-15-intel runner to finish in this PR: 12 minutes.

So faster for sure, but still slow, and more reason to work on parallelizing tests in Issue #1678.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (cad5592) to head (7f27c05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2641   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          65       65           
  Lines        4190     4190           
  Branches      453      453           
=======================================
  Hits         4116     4116           
  Misses         45       45           
  Partials       29       29           
Flag Coverage Δ
contrib 98.11% <ø> (ø)
doctest 98.23% <ø> (ø)
unittests-3.10 96.42% <ø> (ø)
unittests-3.11 96.42% <ø> (ø)
unittests-3.12 96.42% <ø> (ø)
unittests-3.13 96.42% <ø> (ø)
unittests-3.9 96.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 27, 2025 19:59
Copilot finished reviewing on behalf of matthewfeickert November 27, 2025 20:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a workaround for a known macOS 15 performance bug that significantly slows down Intel-based runners by disabling the PerfPowerServices process. The fix is applied consistently across all GitHub Actions workflows that utilize the macos-15-intel runner.

  • Adds a pre-checkout step to disable PerfPowerServices on macos-15-intel runners
  • Applies the workaround consistently across all affected workflow files
  • Includes proper documentation referencing the upstream GitHub issue

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Adds PerfPowerServices workaround step before checkout for the main CI/CD workflow
.github/workflows/dependencies-head.yml Adds PerfPowerServices workaround step before checkout for dependency testing workflow
.github/workflows/release_tests.yml Adds PerfPowerServices workaround step before checkout for release testing workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@matthewfeickert matthewfeickert merged commit 9dd6a2c into scikit-hep:main Nov 27, 2025
29 checks passed
@matthewfeickert matthewfeickert deleted the ci/make-macos-15-not-slow branch November 27, 2025 22:10
@github-project-automation github-project-automation bot moved this from In progress to Done in pyhf v0.8.0 Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI systems, GitHub Actions

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants