Skip to content

Conversation

@hedtke
Copy link
Collaborator

@hedtke hedtke commented Dec 8, 2025

Many methods were already marked as const. The member m_lastReturnCode is always indirectly modified via m_scipCallWrapper.

Now the member m_lastReturnCode is marked mutable and all methods that can be const are now const.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.05%. Comparing base (6ab0c12) to head (33b2e42).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files          10       10           
  Lines         205      206    +1     
  Branches       57       58    +1     
=======================================
+ Hits          201      202    +1     
  Misses          3        3           
  Partials        1        1           
Files with missing lines Coverage Δ
include/scippp/model.hpp 95.83% <100.00%> (ø)
source/model.cpp 98.80% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hedtke hedtke added this to the 1.4.0 milestone Dec 8, 2025
@hedtke hedtke requested a review from wienkamp December 9, 2025 11:45
@wienkamp
Copy link
Collaborator

Only one comment not related to the changes in the MR: I cannot reliably build the 'tests' target with the current project setup: If I first follow the instructions to build the tests target (conan v2, CMake > 3.19) everything works. However, if I first follow the instructions for building the ScipPP target and subsequently want to build the tests target, the error "No rule to make target tests" is thrown. This can be fixed by using tc.cache_variables["BUILD_TESTS"] instead of tc.variables["BUILD_TESTS"] in the conanfile.py. Same holds true for other variables set in the conanfile.py.

@hedtke hedtke merged commit 781cbfb into main Dec 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants