-
Notifications
You must be signed in to change notification settings - Fork 40
docs(vscode): Improve Gradle import tutorial clarity and completeness (#121) #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs(vscode): Improve Gradle import tutorial clarity and completeness (#121) #137
Conversation
|
@damithc @Johnwz123 Thank you for your suggestions on improving the Gradle tutorial. I’ve incorporated the key points we discussed — including clarifications on Gradle support, workspace trust, project structure, JVM configuration, and troubleshooting tips. Please let me know if there’s anything I may have missed or if further refinements are needed — I’d be happy to make additional improvements! |
damithc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes suggested.
|
|
||
| This guide will help you import and work with existing Gradle projects in VS Code. | ||
|
|
||
| 💡 VS Code offers good Gradle support through extensions, though some manual steps may still be needed for a smooth experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arshinsikka Use icons from font-based icons supported by MarkBind, for a consistent look. The emojis you have used vary appearance based on the browser.
See https://markbind.org/userGuide/formattingContents.html#using-font-awesome-icons for more info. If using fontawesome icons, choose free ones only.
| - `src/main/java` | ||
| - `src/test/java` | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not specific to VSCode. Hence, best given in https://se-education.org/guides/tutorials/gradle.html rather than here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue not addressed yet.
| 1. **Navigate to your existing Gradle project** folder | ||
| 1. **Click "Select Folder"** to open it as a workspace | ||
|
|
||
| 💡 When prompted, click "Yes" to trust the workspace so that Gradle tasks and extensions can run correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with other tutorials, use back-ticks when referring to UI elements e.g., Yes instead of "Yes". This might require changes in other places of this page too.
|
|
||
| <pic src="images/vscode/vscode_gradle_icon.jpg" width="400" /> | ||
|
|
||
| ## 🛠️ Troubleshooting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the changes consistent with the rest of the page e.g., other headings don't use emojis
|
Hi @damithc,
Please let me know if there’s anything else to adjust — happy to refine further! 😊 |
|
|
||
| <box type="important" seamless> | ||
|
|
||
| ### 🗂 Typical Gradle Project Structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fully resolved yet e.g., this heading has an emoji
|
Hi Prof @damithc, I've gone ahead and addressed the remaining items:
Please let me know if there’s anything else you'd like tweaked — happy to refine further! |
damithc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added.
| ## Importing an existing Gradle project | ||
|
|
||
| ### Step 1: Open the project folder | ||
| ### ### Step 1: Open the Project Folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right.
| - `src/main/java` | ||
| - `src/test/java` | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue not addressed yet.
|
@arshinsikka Waiting for you to fix the remaining issues |
…section, fix heading, backtick UI labels, convert Gradle view note to info box, drop missing image, minor grammar
|
Hi Prof @damithc — thanks for the nudge! I’ve addressed the remaining items:
Please let me know if you’d like any further tweaks — happy to adjust! |
|
Sorry, it took a while to get to this PR. @arshinsikka it is not advisable for new contributors to send many PRs at once. Maintainers will prioritise other PRs because such multiple PRs from a new contributor means repetitive work e.g., asking to fix the same problem in multiple PRs. It is better to gradually increasing the PR count/size so that you can align your work with the standards of the repo first. |
|
@Johnwz123 Any inputs on this? |
Johnwz123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
| This guide will help you import and work with existing Gradle projects in VS Code. | ||
|
|
||
| <box type="tip" seamless> | ||
| For general Gradle setup guidance, see <a href="https://se-education.org/guides/tutorials/gradle.html" target="_blank">our Gradle tutorial</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| For general Gradle setup guidance, see <a href="https://se-education.org/guides/tutorials/gradle.html" target="_blank">our Gradle tutorial</a>. | |
| For general Gradle setup guidance, see [our Gradle tutorial](https://se-education.org/guides/tutorials/gradle.html). |
For consistency, I think we should stick to the Markdown way of formatting links rather than the HTML way.
| 1. **Check the status bar** at the bottom for any initialization messages | ||
|
|
||
| <box type="tip" seamless> | ||
| If your project uses Gradle, you should see a `build.gradle` or `build.gradle.kts` in the project root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would make more sense to be under the "Prerequisites" section instead as a check for users to verify that the Java project is a Gradle project before proceeding with the rest of the tutorial. What do you think?
| **Confirm you can access the Gradle tool window**. After the importing of the project is complete (which could take a few minutes), you will see the Gradle Tab in the VS Code interface (Look for the elephant icon on the left and click it). | ||
| <box type="info" seamless> | ||
| Open the **Gradle** view from the Activity Bar (elephant icon) to browse and run tasks. | ||
| See: <a href="https://code.visualstudio.com/docs/java/java-build#_gradle-support" target="_blank">VS Code: Java — Build with Gradle</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fragment identifier (#) for the link doesn't seem to exist when I tried? Also, I think it would be better to not wrap it in an "info" box since I think it is an important step to verify that the setup is successful.
| If the Gradle icon doesn't appear after restarting VS Code, add `"gradle.nestedProjects": true` to your `settings.json` file. | ||
| </box> | ||
|
|
||
| <pic src="images/vscode/vscode_gradle_icon.jpg" width="400" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for removing the image?
| Gradle support is included by default in the Java Extension Pack, so no separate Gradle installation is usually required. | ||
| </box> | ||
|
|
||
| <box type="important" seamless> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems out of place?
This PR improves the VS Code tutorial for importing Gradle projects as discussed in issue #121.
Improvements:
gradle -versiontip and JAVA_HOME guidanceThese improvements follow suggestions by @damithc and @Johnwz123.
Closes #121