hardware: Fix platform for compiling X64 and IA32 #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDuchniewicz
force-pushed
the
x86_fixes
branch
from
f5f804b to
710bfac
Compare
Signed-off-by: Jakub Duchniewicz <[email protected]>
lsf37
requested changes
Dec 19, 2025
Member
lsf37
left a comment
lsf37
left a comment
There was a problem hiding this comment.
This doesn't work, it would make the instructions equal between 32 and 64 bit. The instructions for ia32 are correct, they are what CI is using as well. The x64 one has a typo, it needs to be x86_64 instead.
pc99 works, but you get whatever the default is and would still have to set 32 or 64.
Member
|
Closing, since we merged #316 |
Contributor
Author
|
Yes, probably I was too eager to submit that when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong
cmake_platwas specified resulting in creation of a wrong command for sel4test builds.