Quote foreign key constraint names to support numeric table prefixes

[Copilot]

Fix Missing Quotes in Foreign Key Constraint Names

This PR addresses an issue where foreign key constraint names are not properly quoted when table prefixes begin with numeric characters, causing SQL syntax errors in PostgreSQL.

Problem

When using table prefixes that start with a digit (e.g., "1abcd"), creating foreign key constraints fails with a SQL syntax error because the constraint name is not quoted. For example:

alter table "1abcd_UserIndex" add constraint 1abcd_FK_UserIndex foreign key "DocumentId" references "1abcd_Document" ("Id")

The constraint name 1abcd_FK_UserIndex should be quoted.

Solution

Modified the SQL generation to properly quote constraint names in:

1. BaseDialect.GetAddForeignKeyConstraintString - Added QuoteForColumnName() call for constraint names
2. BaseDialect.GetDropForeignKeyConstraintString - Added QuoteForColumnName() call for constraint names
3. PostgreSqlDialect.GetDropForeignKeyConstraintString - Fixed SQL syntax ("drop constraint" vs "drop foreign key") and added quoting
4. MySqlDialect.GetDropForeignKeyConstraintString - Added quoting for constraint names

Testing

• Verified SQL generation with numeric prefix constraint names
• All existing SQLite tests pass (193 passed)
• Added integration test ShouldQuoteForeignKeyConstraintsWithNumericPrefix for PostgreSQL
• Security scan passed with no alerts

Changes

• Fix constraint name quoting in base dialect
• Fix PostgreSQL dialect syntax and quoting
• Fix MySQL dialect quoting
• Add integration test
• Revert temporary TFM changes

Security Summary

No security vulnerabilities were found in the changes.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Missing quotes in some requests ?</issue_title>
<issue_description>Used YesSql version : 3.5.0

We create tenants on Orchard, using Postgres and various table prefixes, like "1abcd". When one of these prefixes begin with a numeric characters, we get an error. Here is a part of the stack trace.

  at YesSql.Sql.SchemaBuilder.Execute(IEnumerable1 statements) in YesSql.Sql\SchemaBuilder.cs:line 50
  at YesSql.Sql.SchemaBuilder.CreateForeignKey(String name, String srcTable, String[] srcColumns, String destTable, String[] destColumns) in YesSql.Sql\SchemaBuilder.cs:line 245
  at YesSql.Sql.SchemaBuilder.CreateMapIndexTable(Type indexType, Action1 table, String collection) in YesSql.Sql\SchemaBuilder.cs:line 74

More generally, in SchemaBuilder, it seems that you can not call CreateMapIndexTable when TablePrefix begins with a digit.

Perhaps, this issue could be solved adding quotes to the Name property of the various ISchemaCommand treated in YesSql.Sql.BaseCommandInterpreter.Create.

However, it would fix the SQL request generated in our case. Here is an exemple of a generated request with the lake of quotes :
alter table "1abcd_UserIndex" add constraint 1abcd_FK_UserIndex foreign key "DocumentId" references "1abcd_Document" ("Id")</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Missing quotes in some requests ? #518

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[sebastienros]

@copilot revert the changes that update the TFMs, dotnet 10 is supported

[Copilot]

@copilot revert the changes that update the TFMs, dotnet 10 is supported

Reverted the TFM changes. All target frameworks restored to net8.0;net10.0 in commit 6088ac5.