-
Notifications
You must be signed in to change notification settings - Fork 94
Add PBR material support for planar texture alignment #4856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
/claim #2975 |
7893b2b to
64ea4f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements planar texture alignment support for PBR (Physically Based Rendering) materials, extending the existing alignment functionality that previously only worked with Blinn-Phong materials. The changes enable the planar alignment checkbox to properly function with PBR texture transforms.
Key Changes:
- Added a new overloaded
calcAlignedPlanarTE()method that accepts explicit transform parameters for PBR materials - Modified
LLPanelFaceSetAlignedTEFunctorto handle both PBR and Blinn-Phong materials based on user selection - Updated alignment logic to apply transforms to appropriate PBR texture channels (individual or all channels when "Complete material" is selected)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| indra/newview/llpanelface.cpp | Core implementation of PBR-aware planar alignment, including functor modifications and logic to apply transforms to PBR material channels |
| indra/newview/llface.h | Declaration of new overloaded calcAlignedPlanarTE() method accepting explicit transform parameters |
| indra/newview/llface.cpp | Implementation of new overloaded method that calculates alignment using provided transform parameters instead of querying from texture entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@akleshchev thanks for review! ci build was failing, i think the errors are not related to what files i changed. should i resolve those in the other files? |
Doesn't look like your fault, but please update from develop to try and resolve it as it runs fine in other PRs. |
b12ce3e to
396d0f9
Compare
396d0f9 to
dbfa839
Compare
done! |
|
I think you need to provide screenshots or videos for this to proceed. But otherwise this should be up to bennettgoble. |
Hi @akleshchev! video attached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aqil-Ahmad Thanks for your work so far. Unfortunately, the alignment is not working as expected. Here's an example:
Given: two planar mapped faces (A, B) with PBR materials.
- Rotate face A by some amount (ex. 20).
- Select face B, then A
- Check "Align planar faces" box
Expected: Faces should align their repeats
Actual: Faces do not align
For an example of how the faces should align see the image above. The upper non-PBR faces have their offset and rotation correctly applied. Performing an identical operation on the PBR materials has a different result. You can see how the face guidelines are continuous across faces.
the misalignment is likely due to the transform convention difference (pbr and bling pong texture). working on it. |
04a8c34 to
571217d
Compare
571217d to
dbfa839
Compare


Description
Implements planar texture alignment for PBR materials, allowing checkbox to work with PBR texture transforms.
Related Issues
Fixes #2975
Issue Link:
Checklist
Please ensure the following before requesting review:
Additional Notes
20251031-0933-17.2299779.mp4