[Draft] Nearby chat voice moderation #4943
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chat moderation might work
…ial code for muting indivudual / everyone via the capability
…allum/voice-moderation-2
…allum/voice-moderation-2
…add stub code for info request
maxim-productengine
changed the title
AndrewMeadows
requested changes
Nov 12, 2025
| LLSD body; | ||
| body["operand"] = operand; | ||
| body["agent_id"] = agent_id; | ||
| body["moderator_id"] = gAgent.getID(); |
Contributor
There was a problem hiding this comment.
There is no need to send the moderator_id: remove it. The server ignores that field and instead grabs the agent_id directly from the connection context.
Contributor
Author
There was a problem hiding this comment.
Will do.
|
|
||
| LLSD body; | ||
| body["operand"] = operand; | ||
| body["moderator_id"] = gAgent.getID(); |
Contributor
There was a problem hiding this comment.
Remove the moderator_id field.
| bool LLFloaterIMContainer::isNearbyChatSpeakerSelected() | ||
| { | ||
| LLFolderViewItem *selectedItem = mConversationsRoot->getCurSelectedItem(); | ||
| if (NULL == selectedItem) |
Contributor
There was a problem hiding this comment.
Has the viewer switched yet to using nullptr (c++-ism) instead of NULL (c-ism)?
Contributor
Author
There was a problem hiding this comment.
In this case it was probably just copy-paste from another place. It's more common just to do if (!selectedItem) check.
Speaking of NULL vs nullptr - there we no switch, but it makes sense to use nullptr at least in the new code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New menu options for Nearby chat moderation are added.
Also new notification will be displayed after being muted/unmuted in Nearby chat or clicking 'voice' button while being muted.