Skip to content

Conversation

@titilambert
Copy link
Member

Ok, I don't get it.
Was this config file correct ? And what is this module exactly ?
What is the real difference with mod-pickle-retention-file-generic ?
If I read well the code, they are identical...
If yes, I think we should delete it...

Ok, I don't get it.
Was this config file correct ? And what is this module exactly ?
What is the real difference with mod-pickle-retention-file-generic ?
If I read well the code, they are identical...
If yes, I think we should delete it...
@naparuba
Copy link
Member

that's about history conf from pre-1.0 version. I don't remember exatly but I changed the module type there.

If we merge, pre-1.0 version will break (bad module type). but after all we are in 2.0+, so why not force old user to update their conf.

It's not a priority so I'll take time to look at the old conf before merge.

@Seb-Solon
Copy link

I had the same problem tonight try to load the module. I had to remove the _generic to make it work :(

I think we should correct this, pre1-0 version should not use this version of code. Module structure has changed (name, init) for 2.0 :)

@mathieumd
Copy link

I had the same problem with a fresh "pip install shinken" (Shinken 2.4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants