Skip to content

Conversation

@Cale146
Copy link

@Cale146 Cale146 commented Feb 23, 2025

Resolves issue #13206 where the member count displayed was inaccurate when creating or modifying groups. The member count now reflects the correct number of participants when selecting/deselecting.

First time contributor checklist

Contributor checklist

  • Motorola Moto G Power 5G, API 34
  • Virtual Device Pixel 9 Pro, API 35
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #13206 syntax

Description

Previously, the displayed member count in the 'X members' message was incorrect when adding/removing members from both new and existing groups. This PR ensures the correct count is shown at all times.

Resolves issue signalapp#13206 where the member count displayed was inaccurate when creating or modifying groups.  The member count now reflects the correct number of participants when selecting/deselecting.
Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will go into 7.36

@Cale146
Copy link
Author

Cale146 commented Feb 24, 2025

Thanks @greyson-signal.

@Sagar0-0
Copy link
Contributor

Sagar0-0 commented Feb 25, 2025

Hi @greyson-signal @Cale146 , I believe this PR is a copy of #13885 , please check and update the attached issue too.

Also, directly calling getSelectedMembersSize() without null check can throw exception, which is covered in my PR :)

@Cale146
Copy link
Author

Cale146 commented Feb 25, 2025

@Sagar0-0, very nice catch and thank you. I should have filtered through the issues a little better before submitting this PR.

@greyson-signal, @Sagar0-0's fix is better, especially with null check. I've tested their PR and can confirm it's working well with the displayed counts.

Is the standard in this project that I close this PR #14011? Or is that something the Signal team does?

@greyson-signal
Copy link
Contributor

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants