-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Fix: Show "declined" string for call instead of "missed" #14081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b819c81 to
0b5ad2f
Compare
jeffrey-signal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This will be included in version 7.40
@jeffrey-signal I need to do one more thing and after that, this PR can be merged ^^. |
|
Hi! Just curious, what's the missing thing for this pr (everything looks good from what I see)? |
Ah, thanks for pointing that out. I believe this pr is already slated for 7.40 since we can take the change as is, so if you want to open a new pr for the second part, that'd be preferred. Or you can leave it in this pr and we'll separate out the commits later - whichever works best for you. |
0b5ad2f to
6a2ff6a
Compare
6a2ff6a to
38b1b55
Compare
|
@mtang-signal @jeffrey-signal I've modified comments on string. If it's ok for you, you can merge it. |
|
Thanks for the contribution :) . I missed your second commit that updated the comments on the string file, but it should be fine. I'll make a note to update it if it causes any confusion down the line. |

First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
All is in the title.