Skip to content

Conversation

@AnonAlly
Copy link
Contributor

@AnonAlly AnonAlly commented Apr 5, 2025

First time contributor checklist

Contributor checklist

  • Fairphone 4 - Android 15
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

All is in the title.

@AnonAlly AnonAlly force-pushed the fix/declined_call branch from b819c81 to 0b5ad2f Compare April 6, 2025 16:27
Copy link
Contributor

@jeffrey-signal jeffrey-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This will be included in version 7.40

@AnonAlly
Copy link
Contributor Author

AnonAlly commented Apr 8, 2025

Thanks for your contribution! This will be included in version 7.40

@jeffrey-signal I need to do one more thing and after that, this PR can be merged ^^.

@mtang-signal
Copy link
Contributor

Hi! Just curious, what's the missing thing for this pr (everything looks good from what I see)?

@AnonAlly
Copy link
Contributor Author

AnonAlly commented Apr 9, 2025

Hi! Just curious, what's the missing thing for this pr (everything looks good from what I see)?

This string don't use "Declined" on Calls tab

signal-2025-04-09-16-50-24-488

@mtang-signal
Copy link
Contributor

Hi! Just curious, what's the missing thing for this pr (everything looks good from what I see)?

This string don't use "Declined" on Calls tab

Ah, thanks for pointing that out. I believe this pr is already slated for 7.40 since we can take the change as is, so if you want to open a new pr for the second part, that'd be preferred. Or you can leave it in this pr and we'll separate out the commits later - whichever works best for you.

@AnonAlly AnonAlly force-pushed the fix/declined_call branch from 0b5ad2f to 6a2ff6a Compare April 9, 2025 19:07
@AnonAlly AnonAlly force-pushed the fix/declined_call branch from 6a2ff6a to 38b1b55 Compare April 9, 2025 19:08
@AnonAlly AnonAlly marked this pull request as ready for review April 9, 2025 19:10
@AnonAlly
Copy link
Contributor Author

AnonAlly commented Apr 9, 2025

@mtang-signal @jeffrey-signal I've modified comments on string. If it's ok for you, you can merge it.

@mtang-signal
Copy link
Contributor

Thanks for the contribution :) . I missed your second commit that updated the comments on the string file, but it should be fine. I'll make a note to update it if it causes any confusion down the line.

isopod-a pushed a commit to isopod-a/Signal-Android that referenced this pull request Apr 15, 2025
@AnonAlly AnonAlly deleted the fix/declined_call branch April 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants