support verify by digest in conformance suite #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02e3919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bdehamer
force-pushed
the
bdehamer/conformance-verify-by-digest
branch
3 times, most recently
from
425e8b8 to
0e2cc17
Compare
Signed-off-by: Brian DeHamer <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
bdehamer
force-pushed
the
bdehamer/conformance-verify-by-digest
branch
from
17b54ac to
02e3919
Compare
ejahnGithub
approved these changes
Dec 4, 2024
Contributor
ejahnGithub
left a comment
ejahnGithub
left a comment
There was a problem hiding this comment.
lgtm! glad that we have wrapper for SignedEntit.signature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CLI for the Sigstore conformance test suite to allow verification of bundles by artifact OR artifact digest.
The most recent release of the Sigstore conformance test suite (v0.0.12) includes verification tests which supply only the digest of the signed artifact instead of supplying the artifact itself. The native nodejs crypto library does NOT support signature verification by digest (you must supply the original artifact and the digest is calculated internally).
To work-around this, I've added a custom implementation of the
SignatureContenttype which uses a third-party library (elliptic) to perform the signature verification by digest. This new library is integrated ONLY with the conformance CLI and is not part of the@sigstore/verifylibrary.