Skip to content

Conversation

@dguido
Copy link
Contributor

@dguido dguido commented Aug 21, 2025

Summary

This PR addresses the repository's maintenance issues by combining several critical updates:

  • Python 3.9 upgrade: Updates minimum Python version from 3.8 (EOL) to 3.9
  • Rekor v1.4.0 update: Brings codebase up-to-date with latest Rekor release
  • Fixed CI/CD pipeline: Resolves failing codegen workflow

Changes

Python Version Upgrade

  • Updated requires-python to >=3.9 in pyproject.toml
  • Updated codegen script to target Python 3.9
  • Removed unnecessary version checks in code

Codegen Improvements

  • Added --use-standard-collections flag to fix typing.Dict deprecation warnings
  • Regenerated all type definitions with datamodel-code-generator v0.33.0
  • All generated code now uses modern Python type hints (e.g., dict instead of Dict)

Rekor Update

  • Updated from v1.3.10 to v1.4.0
  • Regenerated all type schemas with latest definitions

Context

This PR supersedes #166 and addresses the feedback from @woodruffw's review:

  • The upstream datamodel-code-generator issue (#2395) has been resolved
  • The --use-standard-collections flag fixes the typing deprecation issues
  • All lint checks now pass successfully

Testing

  • ✅ All lint checks pass (make lint)
  • ✅ Codegen runs successfully with Python 3.9
  • ✅ Generated code uses proper modern type hints

Next Steps

After merging this PR, we should:

  1. Close the 19+ outdated bot-generated Rekor bump PRs
  2. Review and merge pending Dependabot updates
  3. Consider PR add codegen for rekorv2 #168 for Rekor v2 support

🤖 Generated with Claude Code (https://claude.ai/code)

This comprehensive update addresses multiple maintenance issues:

- Upgrade minimum Python version from 3.8 to 3.9 (Python 3.8 is EOL)
- Update codegen to use Python 3.9 target
- Add --use-standard-collections flag to fix typing deprecations
- Update to latest Rekor version v1.4.0 (was v1.3.10)
- Regenerate all type definitions with latest datamodel-code-generator
- Fix import ordering and remove unnecessary version checks

This resolves the broken CI/CD pipeline that was failing due to
datamodel-code-generator no longer supporting Python 3.8.

Fixes the issues identified in PR #166 and incorporates feedback
from maintainer review.

🤖 Generated with Claude Code (https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Add the --formatters ruff-check ruff-format flag to the datamodel-codegen
invocation to ensure that generated code is automatically formatted correctly.
This matches what was proposed in PR #166 and ensures future codegen runs
(including automated bot runs) produce properly formatted code without
requiring a separate formatting step.
@dguido
Copy link
Contributor Author

dguido commented Aug 21, 2025

Just pushed an update to add the --formatters ruff-check ruff-format flag to the codegen script. This was present in PR #166 and ensures that future codegen runs (including the automated bot) will produce properly formatted code without requiring a separate formatting step.

This makes the codegen process more robust and self-contained, which is especially important for the daily automated workflow.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me 🙂

@dguido dguido merged commit 431dc7a into main Aug 21, 2025
4 checks passed
@dguido dguido deleted the fix-maintenance-python39-rekor-update branch August 21, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants