Depth1 wrap fix #1475
Merged
Depth1 wrap fix #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhasself
reviewed
Nov 27, 2025
Member
mhasself
left a comment
mhasself
left a comment
There was a problem hiding this comment.
Thanks for tracking this down.
It would be helpful to have this in master instead of branch, and to have a unit test for it.
chervias
approved these changes
Dec 2, 2025
Member
|
Ok thanks for this. I really need it on the depth-1 mapmaker branch so I'll merge it now. @mhasself is it ok if we leave a unit test for later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fix the depth1 wrapping issue once and for all. It works for our test case at least.