Add support for AFS deployment #377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npfoss
requested changes
Feb 29, 2020
Collaborator
npfoss
left a comment
npfoss
left a comment
There was a problem hiding this comment.
On my system which aklog says aklog not found, yet I got the following printout when I ran the script:
Checking for AFS on this system
AFS detected, using AFS for deployment
Using kdo
./deploy.sh: 27: kdo: not found
Also, I think there's definitely some code duplication that could be avoided here... maybe making the production question separate and "no" just exiting, then doing the setup that's the same for both, then a ternary statement or something for the two lines which are different?
Collaborator
|
Update from the meeting: we're starting to think maybe this is adding an unnecessary amount of added complexity for two fairly specific use cases. Discuss? |
miriam-rittenberg
force-pushed
the
deploy-rewrite
branch
from
e1c790b to
8fa8d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
deploy.shso that it is possible to deploy overAFSand avoid usingSSH.If the script detects
aklog, it will assume thatAFSis installed and authenticate withkinitto get aKerberos ticket, authenticate to theSIPBcell, and usersyncto deployCourseRoad. If not installed, this script should default back toSSHfor deployment.