Skip to content

Add last page detection to stop unnecessary API calls #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Add last page detection to stop unnecessary API calls #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c683475
Add callback for last page reached
jlkim909 May 23, 2025
cefa6d4
Add last page reached check to prevent unnecessary fetches
jlkim909 May 23, 2025
f0932b6
Clean up indentation of pokemonList logic in HomeViewModel
jlkim909 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../main/kotlin/com/skydoves/pokedex/compose/core/data/repository/home/FakeHomeRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class FakeHomeRepository : HomeRepository {
page: Int,
onStart: () -> Unit,
onComplete: () -> Unit,
onLastPageReached: () -> Unit,
onError: (String?) -> Unit,
): Flow<List<Pokemon>> = flowOf()
}
1 change: 1 addition & 0 deletions .../src/main/kotlin/com/skydoves/pokedex/compose/core/data/repository/home/HomeRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ interface HomeRepository {
page: Int,
onStart: () -> Unit,
onComplete: () -> Unit,
onLastPageReached: () -> Unit,
onError: (String?) -> Unit,
): Flow<List<Pokemon>>
}
5 changes: 5 additions & 0 deletions .../main/kotlin/com/skydoves/pokedex/compose/core/data/repository/home/HomeRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class HomeRepositoryImpl @Inject constructor(
page: Int,
onStart: () -> Unit,
onComplete: () -> Unit,
onLastPageReached: () -> Unit,
onError: (String?) -> Unit,
) = flow {
var pokemons = pokemonDao.getPokemonList(page).asDomain()
Expand All @@ -58,6 +59,10 @@ class HomeRepositoryImpl @Inject constructor(
*/
val response = pokedexClient.fetchPokemonList(page = page)
response.suspendOnSuccess {
if (data.next == null) {
onLastPageReached()
}

pokemons = data.results
pokemons.forEach { pokemon -> pokemon.page = page }
pokemonDao.insertPokemonList(pokemons.asEntity())
Expand Down
4 changes: 3 additions & 1 deletion feature/home/src/main/kotlin/com/skydoves/pokedex/compose/feature/home/HomeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,15 @@ class HomeViewModel @Inject constructor(
) : BaseViewModel() {

internal val uiState: ViewModelStateFlow<HomeUiState> = viewModelStateFlow(HomeUiState.Loading)
private var isLastPageReached = false

private val pokemonFetchingIndex: MutableStateFlow<Int> = MutableStateFlow(0)
val pokemonList: StateFlow<List<Pokemon>> = pokemonFetchingIndex.flatMapLatest { page ->
homeRepository.fetchPokemonList(
page = page,
onStart = { uiState.tryEmit(key, HomeUiState.Loading) },
onComplete = { uiState.tryEmit(key, HomeUiState.Idle) },
onLastPageReached = { isLastPageReached = true },
onError = { uiState.tryEmit(key, HomeUiState.Error(it)) },
)
}.stateIn(
Expand All @@ -52,7 +54,7 @@ class HomeViewModel @Inject constructor(
)

fun fetchNextPokemonList() {
if (uiState.value != HomeUiState.Loading) {
if (uiState.value != HomeUiState.Loading && !isLastPageReached) {
pokemonFetchingIndex.value++
}
}
Expand Down
Loading