Skip to content

Fix missing Kotlin stdlib versions in published POMs #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix missing Kotlin stdlib versions in published POMs #4386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95d44ff
Set version for kotlin-jdk-8
drganjoo Oct 13, 2025
e86bac1
Merge branch 'main' into fahadzub/jdk-8
Nov 6, 2025
9b74d2e
Remove workaround comment
Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions buildSrc/src/main/kotlin/smithy-rs.kotlin-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@ plugins {
// Workaround per: https://github.com/gradle/gradle/issues/15383
val Project.libs get() = the<org.gradle.accessors.dm.LibrariesForLibs>()

// Ensure Kotlin stdlib dependencies have explicit versions in published POMs
configurations.all {
resolutionStrategy {
eachDependency {
if (requested.group == "org.jetbrains.kotlin" && requested.name.startsWith("kotlin-stdlib")) {
useVersion(libs.versions.kotlin.version.get())
}
}
}
}

java {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
Expand Down
12 changes: 12 additions & 0 deletions buildSrc/src/main/kotlin/smithy-rs.publishing-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ plugins {
`maven-publish`
signing
}

val Project.libs get() = the<org.gradle.accessors.dm.LibrariesForLibs>()
// FIXME(publishing): create a real "javadoc" JAR from Dokka output
val javadocJar = tasks.register<Jar>("emptyJar") {
archiveClassifier.set("javadoc")
Expand All @@ -15,6 +17,16 @@ publishing {
from(components["java"])
artifact(javadocJar)

// Fix Kotlin stdlib version in published POM
versionMapping {
usage("java-api") {
fromResolutionOf("runtimeClasspath")
}
usage("java-runtime") {
fromResolutionResult()
}
}

afterEvaluate {
pom {
name.set(project.ext["displayName"].toString())
Expand Down
Loading