Compress ubcp folder into zip during installer build #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the installer build process by compressing the ubcp Cygwin environment folder into a ZIP archive during build time and extracting it during installation, rather than copying individual files. This approach should reduce installer size and potentially improve installation performance.
- Adds compression of the ubcp folder using 7za with maximum compression during build
- Updates NSIS installer script to extract the ZIP archive instead of copying individual files
- Removes the ZIP file after extraction to clean up temporary installation artifacts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| _prog/build-special.sh | Adds 7za compression command to create ubcp.zip archive during build |
| _lib/nsis/ubDistBuild.nsi | Updates installer to copy and extract ZIP instead of individual files |
|
|
||
| ( | ||
| cd "$currentAccessoriesDir"/parts/ubcp/package_ubcp-core | ||
| 7za a -tzip -mx=9 ubcp.zip ubcp |
There was a problem hiding this comment.
The 7za command should include error handling. If compression fails, the build should fail rather than continue with a potentially corrupted or missing archive.
Suggested change
| 7za a -tzip -mx=9 ubcp.zip ubcp | |
| if ! 7za a -tzip -mx=9 ubcp.zip ubcp; then | |
| echo "Error: Failed to create archive with 7za. Exiting build process." >&2 | |
| exit 1 | |
| fi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bash -n _prog/build-special.shhttps://chatgpt.com/codex/tasks/task_e_687b62bf77c8832c85eae0f3959bc915