-
-
Notifications
You must be signed in to change notification settings - Fork 595
feat(iOS, Stack, Tabs, **experimental**): add prop to override user interface style #3342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just naming remarks. Overall it looks good
456200f to
312e01f
Compare
183056b to
feb834c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks good. I'd only ask if we can deduplicate the UserInterfaceStyle props.
Also naming a prop overrideUserInterfaceStyle suggests that this is a boolean. Maybe let's name it userInterfaceStyleOverride or just userInterfaceStyle? I know it's named like this in UIKit but imo id does not make sense. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you
Description
Adds
experimental_userInterfaceStyleprop toRNSScreenStackHeaderConfigandRNSBottomTabsScreenComponentView. This allows enforcing light theme for navigation bars when device is in dark mode, preventing navigation bar flashes on iOS 26.Important
Changes to
react-navigationare required for this PR to work. To test the chagnes, apply the following patch:Patch
theme_before.mov
theme_after.mov
Fixes #3162.
Changes
experimental_userInterfaceStyletoRNSScreenStackHeaderConfigexperimental_userInterfaceStyletoRNSBottomTabsScreenComponentViewTest code and steps to reproduce
Run
Test3342. Please noteIMPORTANTsection above.Checklist