Add support for filtering out private repositories #991
Conversation
This could be useful for internal zoekt instances where internal and public are fine to index for search purposes, but private may not be.
There was a problem hiding this comment.
Semi-unrelated to this change, but
"github.com/google/go-github/v27/github"
This is very old.
I didn't dare try to do a ~50 version bump in this, but the newer version does have a "visibility" attribute for github.Repo, which can be used for this as well, but one could build a list of "public,private,internal" and choose any combination or "all" to index.
With the current version, I could only find a method of adding "private or not".
|
I didn't dare try to do a ~50 version bump in this
If you are willing to do a tiny test, I'm fairly certain bumping
it is fine from experience in using this library in another
repository.
|
|
I ran some local tests, compiling and running zoekt-mirror-github, filtering with visibility seems to work as expected. |
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
Thanks. And thanks again for upgrading the github client. Got one inline comment.
Allows for filtering on Public, Private, Internal repositories or any combination of these. Allows for explicit control of what zoekt clones and indexes from github. * Bump go-github to v78 The visibility attribute is not exposed in older versions of the library.
2 participants
This could be useful for internal zoekt instances where internal and public repositories are fine to index for search purposes, but private may not be.