Make Prefix attribute repeatable #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the `Prefix` attribute as repeatable and update the `ClassRouteAttributes` class to support multiple prefixes. * **Prefix Attribute**: - Mark the `Prefix` attribute in `src/Attributes/Prefix.php` as repeatable by adding `Attribute::IS_REPEATABLE`. * **ClassRouteAttributes**: - Update the `prefix` method in `src/ClassRouteAttributes.php` to return an array of prefixes. - Update the `groups` method in `src/ClassRouteAttributes.php` to handle multiple prefixes. * **Tests**: - Add a test for multiple prefixes in `tests/AttributeTests/PrefixAttributeTest.php`. - Add multiple `Prefix` attributes to the `PrefixTestController` class in `tests/TestClasses/Controllers/PrefixTestController.php`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/spatie/laravel-route-attributes?shareId=XXXX-XXXX-XXXX-XXXX).
Author
|
I took a shot at getting this feature with the help of Copilot Workspace. It worked pretty well, although a few tests didn't pass. Leaving it open to take another try when I have time. |
osbre
suggested changes
Apr 16, 2025
| * @psalm-suppress NoInterfaceProperties | ||
| */ | ||
| public function prefix(): ?string | ||
| public function prefix(): array |
Contributor
There was a problem hiding this comment.
public function prefixes(): array
osbre
reviewed
Apr 16, 2025
Comment on lines
+88
to
+89
| $prefixes = $this->prefix(); | ||
| foreach ($prefixes as $prefix) { |
Contributor
There was a problem hiding this comment.
foreach ($this->prefixes() as $prefix) {
Author
|
Thanks for the reviews and improvements, @osbre! I haven’t had a chance to revisit this, and in the meantime, I’ve found a solution to my use case using the Since it’s not something I plan to continue, I’ll go ahead and close this PR. Feel free to open a new one if you’d like to carry it forward. Thanks again! Sorry for making noise, @freekmurze! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the
Prefixattribute as repeatable and update theClassRouteAttributesclass to support multiple prefixes.Prefix Attribute:
Prefixattribute insrc/Attributes/Prefix.phpas repeatable by addingAttribute::IS_REPEATABLE.ClassRouteAttributes:
prefixmethod insrc/ClassRouteAttributes.phpto return an array of prefixes.groupsmethod insrc/ClassRouteAttributes.phpto handle multiple prefixes.Tests:
tests/AttributeTests/PrefixAttributeTest.php.Prefixattributes to thePrefixTestControllerclass intests/TestClasses/Controllers/PrefixTestController.php.For more details, open the Copilot Workspace session.