feat: Add JSON object navigation #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagarnica
commented
Jul 1, 2025
Comment on lines
21
to
57
| const encodeLog = (log: SandpackConsoleData): Message => { | ||
| // deep copy the log.data array | ||
| if (!log.data) { | ||
| return Decode([]) as Message; | ||
| } | ||
| const modifiedDataArray = log.data as [Message, string]; | ||
| if (Array.isArray(modifiedDataArray)) { | ||
| // Due to formatting changes with console-feed's encode function in v3.4 | ||
| // we need to manually add in the remainder key to note that there | ||
| // are no more items remaining | ||
| modifiedDataArray.push("__console_feed_remaining__0"); | ||
| // Objects all need to have a constructor property now too | ||
| // unless it is null | ||
| modifiedDataArray.forEach((dataItem) => { | ||
| if ( | ||
| typeof dataItem !== "string" && | ||
| (dataItem as unknown as SandpackEncodedLog)?.["@t"] | ||
| ) { | ||
| const sandpackEncodedLog = dataItem as unknown as SandpackEncodedLog; | ||
| if (sandpackEncodedLog["@t"] === "[[undefined]]") { | ||
| return; | ||
| } | ||
|
|
||
| // Hey keep going and actually write this as a function to note | ||
| // that we are essentially an adapter for v3.3 and the newest version of console-feed | ||
| const constructorType = sandpackEncodedLog?.["@t"]?.slice(2, -2); | ||
| Object.assign(dataItem, { | ||
| constructor: { | ||
| name: constructorType, | ||
| }, | ||
| }); | ||
| delete sandpackEncodedLog["@t"]; | ||
| } | ||
| }); | ||
| } | ||
| return Decode([{ ...log, data: modifiedDataArray }]) as Message; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
This is the adapter required to go from v3.3 to v3.8 or newer. Sandpack already encodes the console messages with console-feed but using v3.3, causing some odd crashes and type issues since we are using 3.8 to decode. We could also use v3.3 for console-feed but we lose React 19 support.
jagarnica
commented
Jul 1, 2025
Comment on lines
+78
to
+80
| background: "var(--sp-colors-surface1)", | ||
| lineHeight: "var(--sp-font-lineHeight)", | ||
| }} |
Contributor
Author
There was a problem hiding this comment.
These tokens will be replaced in the following PR for styles.
jagarnica
commented
Jul 1, 2025
Comment on lines
+83
to
+87
| export const ConsoleOutputWithDifferentDataTypes: Story = { | ||
| args: { | ||
| defaultValue: `// Console output with different data types | ||
| // This story stress tests the console output with various JavaScript data types | ||
Contributor
Author
There was a problem hiding this comment.
This adds a stress test for the console output.
jagarnica
commented
Jul 1, 2025
Comment on lines
+38
to
+44
| // Disable unused exports rule for Storybook files | ||
| { | ||
| files: ["**/*.stories.{ts,tsx}", ".storybook/*.{ts,tsx}"], | ||
| rules: { | ||
| "fast-import/no-unused-exports": "off", | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Disabling these rules just for storybook files
nebrius
reviewed
Jul 1, 2025
packages/docs-md/src/components/TryItNow/ConsoleOutput/index.tsx
Outdated
Show resolved
Hide resolved
nebrius
approved these changes
Jul 1, 2025
Contributor
nebrius
left a comment
nebrius
left a comment
There was a problem hiding this comment.
Meant to hit approve. Looks good aside from two small things.
pschutz93
pushed a commit
that referenced
this pull request
Oct 25, 2025
* add basic storybook setup * add basic nesting view to jsonViewer * add indentation levels and basic color mapping * add nesting example and fix comma bug * add no wrap to avoid breaking spaces * add null syntax coloring * fix expansion bug with duplicate keys * refactor for perf improvements * add proper color theming to json viewer * update dependencies * add console-feed and console-feed adapter * removing testing output * add more comments * update package-lock * remove ref from SandpackPreview * disable import rules for eslint * remove storybook from tsconfig * ignore bootstrap storybook files in eslint * remove unneeded type and add image types to lfs gitattributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds