-
Notifications
You must be signed in to change notification settings - Fork 263
Use spring-boot-starter-parent in spring-batch-elasticsearch
#168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>1.5.22.RELEASE</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest 1.5 available.
Moving to a higher major version requires refactoring of the item reader and writer due to breaking changes, which would be beyond the scope of this PR.
| <configuration> | ||
| <flattenMode>ossrh</flattenMode> | ||
| <pomElements> | ||
| <developers>remove</developers> <!-- FIXME remove once the developers are defined --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fmbenhassine, I understand from #166 (comment) that @hpoettker will maintain this module.
Since I couldn't add their handle for review, I assume the onboarding is not complete yet.
Therefore, I haven't added any developers section to the POM and added this parameter to prevent pulling the ones defined in the spring-boot-starter-parent.
Signed-off-by: Stefano Cordio <[email protected]>
67ad345 to
995506c
Compare
|
Hi @hpoettker, I just added you to this PR but feel free to close it if you plan some more aggressive refactoring 🙂 |
|
@scordio Thank you for this PR and for following up on this!
The onboarding was completed. @hpoettker is part of this org now and has push access to the repository.
Since Batch 6 and Boot 4 are out, and in order to reduce the maintenance effort of multiple versions, I would make v1 of this elasticsearch module based on the latest versions (as Spring Batch 5.2 will be out of OSS support in a few months from now). But I will let @hpoettker decide what to do with this regard. |
Similar to #159, #163, and #165, this PR:
spring-boot-starter-parentto keep all the dependency and plugin versions alignedflatten-maven-pluginwithossrhflatten mode to strip all the unnecessary details from the final POMFlattened POM