Add property to automatically register a ContextPropagatingTaskDecorator bean #48385
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
requested changes
Dec 3, 2025
Member
snicoll
left a comment
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please run the build locally to make sure formatting and checkstyle checks are passing.
I've added a few comments for your consideration.
...igure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionProperties.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java
Outdated
Show resolved
Hide resolved
snicoll
added
the
status: waiting-for-feedback
Signed-off-by: Sandipan <[email protected]>
Signed-off-by: Sandipan <[email protected]>
Signed-off-by: Sandipan <[email protected]>
philwebb
changed the title
Member
|
@sbera13 the build is failing, can you please check? |
Member
|
Alright I am taking over. |
snicoll
added
type: enhancement
Member
|
Sorry @sbera13 but reviewing the PR there's not much that's left from the original contribution. The code doesn't compile, checkstyle is failing and the tests are all failing as well. Going forward, please run the build on the command line and make sure the code you've added doesn't break it. |
snicoll
added
the
status: declined
Author
|
@snicoll My apologies for not being active enough on this. Thanks for taking care of this. Will keep your suggestions in mind from next time. |
snicoll
added a commit
to snicoll/spring-boot
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #48033. It has the following changes
propagateContextContextPropagatingTaskDecoratorbased on the property