v7 Next Backports #2287
Merged
v7 Next Backports #2287
+12
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-cache#2286) The method is unreachable: It was supposed to be a virtual method. It is declared as such in HttpStateData class, but it should have been declared virtual in Client (i.e. the _parent_ class). Without that virtual declaration in Client, the caller calls a Client method with the same name instead. This code became unreachable in 2007 commit 5f8252d. The current method implementation is unusable: There are two explicit XXXs, excessive (and unclassified) level-1 debugging, and an infinite recursion added in the same 2007 commit 5f8252d. It is possible to refactor this method implementation to address known concerns. We decided to remove this method instead because proper refactoring is costly and is likely to result in this method removal. The infinite recursion concern was raised by Joshua Rogers https://joshua.hu/
…cache#2216) Previously, various null-pointer dereferences, UAFs, and so on occurred.
yadij
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.