Ring SSEGen refactor #12
Merged
+41
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The previous implementation used a complicated logic involving locks to protect against an api usage that should not happen. The protection is now removed, the code is much simpler.
JeremS
force-pushed
the
jetty-simplification
branch
from
3d1daf3 to
0b66653
Compare
Contributor
|
@JeremS I won't be able to look at this until Monday, sorry about that. |
Collaborator
Author
|
@Ramblurr I can wait till then! |
Ramblurr
approved these changes
Dec 11, 2025
Contributor
Ramblurr
left a comment
Ramblurr
left a comment
There was a problem hiding this comment.
This looks good, the ring generator much cleaner now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides some minor fixes (mostly to examples and docstrings) this PR's goal is to simplify the Ring SSEGen implementation.
Currently the Ring SSE generator prevents users from fiddling with internals. More specifically it throws if a user tries to reuse a SSEGenerator as a ring response body in more than one response.
This is unlikely to happen, the current documentation explicitly explains how to use the API and this protection makes for convoluted code involving locks.
The proposed implementation from this PR removes that protection to allow for a much simpler code.