Python SDK: Make examples executable and lint/format all python code #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signals found Allows read_signals to be used as a dependency in fastapi or litestar
Factor out a common implementation for all the frameworks.
Make all the example scripts directly runnable.
- Add settings and lint/format all files with ruff - Update all examples to use datastar 1.0 beta 11 - Make all examples executable directly with uv
Contributor
Author
lllama
approved these changes
Jun 2, 2025
Collaborator
|
Please resolve conflicts and I’ll merge. |
# Conflicts: # examples/python/django/ds/views.py # examples/python/fastapi/app.py # examples/python/fasthtml/simple.py # examples/python/litestar/app.py # examples/python/quart/app.py # examples/python/sanic/app.py # sdk/python/src/datastar_py/django.py # sdk/python/src/datastar_py/fastapi.py # sdk/python/src/datastar_py/fasthtml.py # sdk/python/src/datastar_py/litestar.py # sdk/python/src/datastar_py/quart.py # sdk/python/src/datastar_py/sanic.py # sdk/python/src/datastar_py/starlette.py
bencroker
approved these changes
Jun 2, 2025
Collaborator
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few cleanups in here that I've separated out from #850.
uv run examples/python/sanic/app.pywill install necessary python and deps and run the example.I did this on top of the branch from #850 to avoid having to fix merge conflicts, assuming that will go in. The diff for just this change can be viewed here gazpachoking/datastar@read_signals...gazpachoking:datastar:new_cleanup